[Webkit-unassigned] [Bug 93467] Change ImageSource to be asynchronous.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93467





--- Comment #6 from Hin-Chung Lam <hclam at google.com>  2012-08-09 13:32:01 PST ---
(From update of attachment 157406)
View in context: https://bugs.webkit.org/attachment.cgi?id=157406&action=review

> Source/WebCore/ChangeLog:24
> +        No new tests - existing image tests cover these cases.

I believe image layout tests will verify the correctness of this change, but it's best to list the tests here, e.g.

compositing/images/content-image-change.html
fast/images/jpeg-with-color-profile.html

> Source/WebCore/platform/graphics/BitmapImage.cpp:-132
> -    ASSERT(m_decodedSize == 0 || numFrames > 1);

I think we don't need to change this line in this patch.

> Source/WebCore/platform/graphics/ImageSource.cpp:147
> +    ASSERT(m_observer);

I don't think this is necessary since constructor always have this assigned. If this is 0 it will crash in the following line anyway.

> Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:307
> +    ASSERT(m_observer);

I don't think ASSERT is needed here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.