[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #31 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-09 01:53:25 PST ---
(In reply to comment #23)
> (From update of attachment 154833 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154833&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1105
> > +    EINA_SAFETY_ON_NULL_RETURN(smartData->api->input_picker_show);
> 
> EINA_SAFETY_ON_NULL_RETURN will complain when input_picker_show is null.
> 
> please change this as `if () return;

Ryuan, EINA_SAFETY_ON_NULL_RETURN() is already being used by WK2 ewk_view.cpp as below,

 EINA_SAFETY_ON_NULL_RETURN(smartData->api->focus_in);

Is it better to complain when input_picker_show is null ? How do you think about it ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.