[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #30 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-09 00:13:10 PST ---
(From update of attachment 157372)
View in context: https://bugs.webkit.org/attachment.cgi?id=157372&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1106
> +    if (!smartData->api->input_picker_show)

I think EINA_SAFETY_ON_NULL_RETURN(smartData->api->input_picker_show) is more simple.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1117
> +    if (!smartData->api->input_picker_hide)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1151
> +    if (!priv->colorChooser)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1168
> +    if (!priv->colorChooser)

ditto.

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.cpp:49
> +    if (m_client)

Generally, WebKit prefers to use early return as below,
   if (!m_client)
       return;

If this function will have more function calls, I think early return is better.

See also, WebColorChooserProxyQt.cpp

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.cpp:55
> +    if (m_client)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.