[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 22:45:06 PDT 2012


--- Comment #27 from KwangYong Choi <ky0.choi at samsung.com>  2012-08-08 22:45:28 PST ---
(From update of attachment 157372)
View in context: https://bugs.webkit.org/attachment.cgi?id=157372&action=review

I will find available test for this patch. It changes layout of <input type="color">. So, it will change some test related color type of input.

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:72
>> +
> I think that you should rebase.


>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1154
>> +    priv->colorChooser->setSelectedColor(Color(color));
> You should check whether color is null and valid.
> If color is null, it will be crashed.
> please fix and make test case.


>> Source/WebKit2/UIProcess/API/efl/ewk_view.h:75
> White space in last letter.


>> Source/WebKit2/UIProcess/API/efl/ewk_view.h:473
>> + * @param color the color value to be set
> Could you address which kinds of string is allowed.

It is possible to set color by named color or #000000 style.

Do you think it's better to mention this on parameter description?

>> Source/WebKit2/UIProcess/API/efl/ewk_view_private.h:82
> I prefer to add empty line.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list