[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #26 from Ryuan Choi <ryuan.choi at samsung.com>  2012-08-08 21:59:49 PST ---
(From update of attachment 157372)
View in context: https://bugs.webkit.org/attachment.cgi?id=157372&action=review

I think that patch itself is almost done.
If possible, I want to add test cases for this.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:72
> +#if ENABLE(INPUT_TYPE_COLOR)
> +    WebColorChooserProxyEfl* colorChooser;
> +#endif
> +

I think that you should rebase.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1154
> +    priv->colorChooser->setSelectedColor(Color(color));

You should check whether color is null and valid.
If color is null, it will be crashed.

please fix and make test case.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:75
> +    EWK_INPUT_TYPE_TELEPHONE = 1, 

White space in last letter.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:473
> + * @param color the color value to be set

Could you address which kinds of string is allowed.

> Source/WebKit2/UIProcess/API/efl/ewk_view_private.h:82
> +void ewk_view_input_picker_close(Evas_Object* ewkView, Ewk_Input_Type inputType);
> +#if ENABLE(INPUT_TYPE_COLOR)

I prefer to add empty line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.