[Webkit-unassigned] [Bug 92818] REGRESSION: WebKit does not render selection in non-first ruby text nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92818





--- Comment #7 from Sukolsak Sakshuwong <sukolsak at google.com>  2012-08-01 14:48:25 PST ---
(In reply to comment #3)
> > Source/WebCore/ChangeLog:14
> > +        No new tests (OOPS!).
> 
> You need to mention the test you're adding here. See other change log entries for an example.

Will fix.

(In reply to comment #6)
> > Source/WebCore/ChangeLog:12
> > +        RenderRubyRun is an 'inline-block/table'-like object and therefore should be
> > +        a selection root. However, because it's anonymous, the isSelectionRoot() method
> > +        returned false. This caused RootInlineBox::selectionTopAdjustedForPrecedingBlock
> > +        to return incorrect values and caused the highlight to not show up.
> > +        Make isSelectionRoot() return true for anonymous inline-block objects.
> 
> Driveby comment: To cater for the RubyRun case you're opening up isSelectionRoot() to all inline blocks and tables. This might be fine, but I think you need more tests to show that's the case.

Thanks for the comment. Since isSelectionRoot() has already returned true for all non-anonymous inline-block objects, I just opened it up for anonymous inline-block objects as well. Do we have anonymous inline-blocks objects (or anonymous inline tables) in WebKit other than RubyRun?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.