[Webkit-unassigned] [Bug 92818] REGRESSION: WebKit does not render selection in non-first ruby text nodes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 13:49:39 PDT 2012


--- Comment #6 from Robert Hogan <robert at webkit.org>  2012-08-01 13:49:38 PST ---
(From update of attachment 155722)
View in context: https://bugs.webkit.org/attachment.cgi?id=155722&action=review

> Source/WebCore/ChangeLog:12
> +        RenderRubyRun is an 'inline-block/table'-like object and therefore should be
> +        a selection root. However, because it's anonymous, the isSelectionRoot() method
> +        returned false. This caused RootInlineBox::selectionTopAdjustedForPrecedingBlock
> +        to return incorrect values and caused the highlight to not show up.
> +        Make isSelectionRoot() return true for anonymous inline-block objects.

Driveby comment: To cater for the RubyRun case you're opening up isSelectionRoot() to all inline blocks and tables. This might be fine, but I think you need more tests to show that's the case.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list