[Webkit-unassigned] [Bug 85131] [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85131


Sudarsana Nagineni <naginenis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |naginenis at gmail.com
                   |kit.org                     |




--- Comment #3 from Sudarsana Nagineni <naginenis at gmail.com>  2012-04-29 04:35:26 PST ---
(In reply to comment #2)
> Looks good, but there's one change I suggest...
> 
> > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:916
> > +    size_t bufferSize = JSStringGetMaximumUTF8CStringSize(scheme);
> > +    GOwnPtr<gchar> schemeBuffer(static_cast<gchar*>(g_malloc(bufferSize)));
> > +    JSStringGetUTF8CString(scheme, schemeBuffer.get(), bufferSize);
> > +
> > +    SchemeRegistry::setDomainRelaxationForbiddenForURLScheme(forbidden, String::fromUTF8(schemeBuffer.get()));
> 
> Most of the DumpRenderTreeSupportGtk method use char* instead of JSString. You should do the conversion in LayoutTestController.

Thanks for the review Martin. I will make this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.