[Webkit-unassigned] [Bug 85131] [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85131


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139348|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-04-28 09:10:57 PST ---
(From update of attachment 139348)
View in context: https://bugs.webkit.org/attachment.cgi?id=139348&action=review

Looks good, but there's one change I suggest...

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:916
> +    size_t bufferSize = JSStringGetMaximumUTF8CStringSize(scheme);
> +    GOwnPtr<gchar> schemeBuffer(static_cast<gchar*>(g_malloc(bufferSize)));
> +    JSStringGetUTF8CString(scheme, schemeBuffer.get(), bufferSize);
> +
> +    SchemeRegistry::setDomainRelaxationForbiddenForURLScheme(forbidden, String::fromUTF8(schemeBuffer.get()));

Most of the DumpRenderTreeSupportGtk method use char* instead of JSString. You should do the conversion in LayoutTestController.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.