[Webkit-unassigned] [Bug 85139] MessagePort must set m_closed to be true at the end of MessagePort::close function

Sat Apr 28 12:18:32 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=85139

--- Comment #6 from Li Yin <li.yin at intel.com>  2012-04-28 12:18:31 PST ---
(In reply to comment #5)
> (From update of attachment 139368 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139368&action=review
> 
> > LayoutTests/fast/events/message-port-close.html:1
> > +<body>
> 
> Nit: Shall we use a standard HTML format?
> 
> <!DOCTYPE html><html><head></head><body>...</body></html>
> 
> > LayoutTests/fast/events/message-port-close.html:4
> > +<p>Test Closed MessagePort Whether Receive Message Or Not.</p>
> > +<p>Should be a START message, followed with DONE.</p>
> > +<pre id=log></pre>
> 
> It would be better to use js-test-pre.js and js-test-post.js. You can use a series of methods for tests (e.g. debug("..."), shouldBe("...") etc). Please look at other layout tests using them.

I am following the format of LayoutTests/fast/events/message-port-clone.html, it seems that all of MessagePort related test cases used this format.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.