[Webkit-unassigned] [Bug 85139] MessagePort must set m_closed to be true at the end of MessagePort::close function

Sat Apr 28 12:12:52 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=85139

--- Comment #5 from Kentaro Hara <haraken at chromium.org>  2012-04-28 12:12:51 PST ---
(From update of attachment 139368)
View in context: https://bugs.webkit.org/attachment.cgi?id=139368&action=review

> LayoutTests/fast/events/message-port-close.html:1
> +<body>

Nit: Shall we use a standard HTML format?

<!DOCTYPE html><html><head></head><body>...</body></html>

> LayoutTests/fast/events/message-port-close.html:4
> +<p>Test Closed MessagePort Whether Receive Message Or Not.</p>
> +<p>Should be a START message, followed with DONE.</p>
> +<pre id=log></pre>

It would be better to use js-test-pre.js and js-test-post.js. You can use a series of methods for tests (e.g. debug("..."), shouldBe("...") etc). Please look at other layout tests using them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.