[Webkit-unassigned] [Bug 84446] [GTK] Build and run TestWebKitAPI WebKit2 unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84446





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-24 09:00:54 PST ---
(In reply to comment #4)
> (From update of attachment 138083 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138083&action=review
> 
> >>> Tools/Scripts/run-gtk-tests:83
> >>> +                    "Test fails")
> >> 
> >> Can these failures be tracked in bugzilla if possible?
> > 
> > Yes, I haven't opened bugs for them yet, because they don't actually exist. It's chicken-egg problem, so my idea was to update it once bugs are filed.
> 
> It might be good to at least understand why the spacebar test fails. With it failing, it's hard to know if the code you wrote to support sending key events is working properly.

There are other tests using simulateSpacebarKeyPress() that pass. The problem is that test doesn't fail but hangs. I'll work on every single test that don't pass as soon as this patch lands and bug reports are filed for them. 

> > Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:76
> > +    gtk_main_do_event(event.get());
> > +    event->key.type = GDK_KEY_RELEASE;
> > +    gtk_main_do_event(event.get());
> 
> Is it okay for this to happen asynchronously or do the tests expect that it be finished by the time the method returns?

I'm not sure, why?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.