[Webkit-unassigned] [Bug 84446] [GTK] Build and run TestWebKitAPI WebKit2 unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84446





--- Comment #5 from Philippe Normand <pnormand at igalia.com>  2012-04-24 08:56:13 PST ---
(In reply to comment #3)
> 
> > > Tools/TestWebKitAPI/GNUmakefile.am:61
> > > +testwebkitapi_wtf_tests_cppflags = \
> > 
> > Ditto
> 
> In previous patch there are no other tests, I don't think it's a problem to changing it here, but I can do that in the other patch if you want.
> 

It's not technically a problem but it contributes to make this patch bigger and slightly lower reviewer's motivation (at least in my very personal case) :). Anyway no big deal I guess.

> > > Tools/TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:65
> > > +    return g_filename_to_utf8(value, -1, 0, &bytesWritten, 0);
> > 
> > I find it a bit strange to use g_filename_to_utf8() here. Maybe some day we'll have env variables not dealing with file paths. Or maybe it's just this function that should be renamed :)
> 
> I copied this from WTR
> 

Ok but nevertheless :) I was just a bit surprised by the name of this function vs its code using g_file API. It's probably to keep it as it is but FTR that name doesn't make much sense to me :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.