[Webkit-unassigned] [Bug 84695] [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84695





--- Comment #4 from Philippe Normand <pnormand at igalia.com>  2012-04-24 08:16:47 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 138528 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=138528&action=review
> > 
> > Nice stuff! Looks good to me.
> > 
> > > Tools/Scripts/run-gtk-tests:271
> > > +            if timeout > 0:
> > > +                alarm(0)
> > 
> > I'm not sure to understand this code. Can you clarify please?
> 
> alarm(0) just resets the alarm so that no new alarms are scheduled.
> 

Ok.

> > > Tools/Scripts/run-gtk-tests:307
> > > +        timedout_tests = []
> > 
> > Hum, what about slow_tests?
> 
> I don't think there's any test so slow, in any case we could use a value higher than 10, but I think 10 seconds per test is enough.

I guess I meant the "timedout_tests" name wasn't great but that's only my opinion. I proposed slow_tests because I couldn't come up with a better name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.