[Webkit-unassigned] [Bug 84695] [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84695





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-24 07:43:28 PST ---
(In reply to comment #2)
> (From update of attachment 138528 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138528&action=review
> 
> Nice stuff! Looks good to me.
> 
> > Tools/Scripts/run-gtk-tests:271
> > +            if timeout > 0:
> > +                alarm(0)
> 
> I'm not sure to understand this code. Can you clarify please?

alarm(0) just resets the alarm so that no new alarms are scheduled.

> > Tools/Scripts/run-gtk-tests:307
> > +        timedout_tests = []
> 
> Hum, what about slow_tests?

I don't think there's any test so slow, in any case we could use a value higher than 10, but I think 10 seconds per test is enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.