[Webkit-unassigned] [Bug 84325] [GTK] Build and run TestWebKitAPI unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84325





--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-24 08:02:30 PST ---
(In reply to comment #14)
> (From update of attachment 137912 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137912&action=review
> 
> r=me but please address the following questions before landing:
> 
> > ChangeLog:9
> > +        * GNUmakefile.am: Include makefiles to build gtest and
> > +        TestWebKitAPI. Add BUILDING_WEBKIT2__ macro to compilation when
> 
> What about -DWTF_ENABLE_WEBKIT2 like Martin suggested?

ENABLE macros are of features, but we want to know whether we are building wk2 or not. WebKit2 is not a feature.

> > Tools/Scripts/run-gtk-tests:255
> > +    def _run_test_google(self, test):
> 
> can this be renamed to _run_test_gtester or _run_gtester?

gtester is actually the glib test command, it would be gtest. Since it's indeed confusing I decided to use glib and google instead of gtester and gtest.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.