[Webkit-unassigned] [Bug 84325] [GTK] Build and run TestWebKitAPI unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84325


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137912|review?                     |review+
               Flag|                            |




--- Comment #14 from Philippe Normand <pnormand at igalia.com>  2012-04-24 07:51:46 PST ---
(From update of attachment 137912)
View in context: https://bugs.webkit.org/attachment.cgi?id=137912&action=review

r=me but please address the following questions before landing:

> ChangeLog:9
> +        * GNUmakefile.am: Include makefiles to build gtest and
> +        TestWebKitAPI. Add BUILDING_WEBKIT2__ macro to compilation when

What about -DWTF_ENABLE_WEBKIT2 like Martin suggested?

> Tools/Scripts/run-gtk-tests:255
> +    def _run_test_google(self, test):

can this be renamed to _run_test_gtester or _run_gtester?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.