[Webkit-unassigned] [Bug 58443] [GTK] Support the file system API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 03:47:36 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=58443





--- Comment #40 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-04-24 03:47:35 PST ---
(In reply to comment #39)
> (From update of attachment 138384 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138384&action=review
> 
> This patch seems a bit too big to review at once. Why not try splitting it up? Since the API is divided into operations it makes sense to implement one per patch and unskip tests that pass with each iteration.
Hmm.. I want to hear kov's thought. 

> One thing that I wonder about looking at this initially is the threading behavior. Instead of actually using the asychronous GIO APIs, the operations are just posted back to the main thread. That seems wrong -- unless this is supposed to be called from workers and all operations need to be on the main thread. Is that the case? If so perhaps it would be better to have a "filesystem thread" so that these operations don't block the main thread.
Reasonable. How about sharing fileThread that is used by BLOB?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list