[Webkit-unassigned] [Bug 58443] [GTK] Support the file system API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58443


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138384|review?                     |review-
               Flag|                            |




--- Comment #39 from Martin Robinson <mrobinson at webkit.org>  2012-04-23 22:05:33 PST ---
(From update of attachment 138384)
View in context: https://bugs.webkit.org/attachment.cgi?id=138384&action=review

This patch seems a bit too big to review at once. Why not try splitting it up? Since the API is divided into operations it makes sense to implement one per patch and unskip tests that pass with each iteration.

One thing that I wonder about looking at this initially is the threading behavior. Instead of actually using the asychronous GIO APIs, the operations are just posted back to the main thread. That seems wrong -- unless this is supposed to be called from workers and all operations need to be on the main thread. Is that the case? If so perhaps it would be better to have a "filesystem thread" so that these operations don't block the main thread.

> Source/WTF/wtf/gobject/GOwnPtr.cpp:54
> +template <> void freeOwnedGPtr<GOutputStream>(GOutputStream* ptr)
> +{
> +    g_output_stream_close(ptr, 0, 0);
> +}
> +

GOutputStream is a reference counted GObject, so you should not use GOwnPtr to manage it. g_output_stream_close doesn't free a GOuputStream, only the internal bits.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.