[Webkit-unassigned] [Bug 84542] [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 00:11:00 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84542





--- Comment #6 from Li Yin <li.yin at intel.com>  2012-04-24 00:10:59 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (From update of attachment 138265 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=138265&action=review
> > > 
> > > > Source/WebCore/ChangeLog:12
> > > > +        No new tests. The current test has covered it already.
> > > 
> > > Which test?
> > This patch just deleted a duplicated statement. It can't impact any features. So no test case is required.
> 
> You said in the change log that "The current test has covered it already."
> 
> Which test covers this? Which test will fail if this value is incorrect? (It would be nice to make sure something is going to fail if someone changes the default value in chromium.)
> 
> Why is this change being done? :)
> 
Okay, I will change the log, thanks for your detailed review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list