[Webkit-unassigned] [Bug 84542] [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84542





--- Comment #5 from David Levin <levin at chromium.org>  2012-04-24 00:00:33 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 138265 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=138265&action=review
> > 
> > > Source/WebCore/ChangeLog:12
> > > +        No new tests. The current test has covered it already.
> > 
> > Which test?
> This patch just deleted a duplicated statement. It can't impact any features. So no test case is required.

You said in the change log that "The current test has covered it already."

Which test covers this? Which test will fail if this value is incorrect? (It would be nice to make sure something is going to fail if someone changes the default value in chromium.)

Why is this change being done? :)

> > 
> > > Source/WebCore/workers/Worker.cpp:75
> > >  #endif
> > 
> > Should we add an assert here to verify the target type?
> There isn't public function to get the target type in current code, if we need to assert the target type, I must add the new function for chromium platform, it indeed adds the difficulty of code.
> And in WorkerScriptLoader Constructor, there is a obvious statement about the target type, and no change about the value. Maybe it isn't necessary to add the assert statement. do you think so?
> 
> Thanks for your review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.