[Webkit-unassigned] [Bug 78193] Inserting a paragraph between quoted lines in editing/deleting/delete-4038408-fix.html doesn't work

Sat Apr 21 18:56:34 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=78193

--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2012-04-21 18:56:34 PST ---
(From update of attachment 135364)
View in context: https://bugs.webkit.org/attachment.cgi?id=135364&action=review

> Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:230
>              // We can get here if we pasted a copied portion of a blockquote with a newline at the end and are trying to paste it
>              // into an unquoted area. We then don't want the newline within the blockquote or else it will also be quoted.
> -            if (Node* highestBlockquote = highestEnclosingNodeOfType(canonicalPos, &isMailBlockquote))
> -                startBlock = static_cast<Element*>(highestBlockquote);
> +            if (m_pasteBlockqutoeIntoUnquotedArea) {

Alternatively, can we check is we're at the end of blockquote or not?
This trick should only be used when we're inserting a new paragraph at the end of a blockquote, right?
Can we check whether there's a content between canonicalPos and the end of the mail blockblock?
And adjust startBlock only if we don't have any contents there?

> LayoutTests/editing/inserting/insert-paragraph-separator-in-blockquote.html:16
> +<title></title>

No need for title.

> LayoutTests/editing/inserting/insert-paragraph-separator-in-blockquote.html:48
> +pressKey("\n");

Can't we just do document.execCommand('InsertParagraph', false, null) ?

> LayoutTests/editing/pasteboard/paste-wrapped-blockquote-into-nonblockquote-expected.txt:1
> +This test ensures the copied the newline is NOT inside the blockquote.

We should describe what we should expect to see below.

> LayoutTests/editing/pasteboard/paste-wrapped-blockquote-into-nonblockquote.html:1
> +<html>

No DOCTYPE?

> LayoutTests/editing/pasteboard/paste-wrapped-blockquote-into-nonblockquote.html:10
> +    <style>
> +        blockquote {
> +            color: blue;
> +            border-left: 2px solid blue;
> +            margin: 0px;
> +            padding: 0 0 0 20px;
> +        }
> +    </style>

No need to indent style element and rules like this.

> LayoutTests/editing/pasteboard/paste-wrapped-blockquote-into-nonblockquote.html:19
> +    var range = document.createRange();

No need to indent script contents.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.