[Webkit-unassigned] [Bug 78193] Inserting a paragraph between quoted lines in editing/deleting/delete-4038408-fix.html doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78193





--- Comment #16 from yi shen <yi.4.shen at nokia.com>  2012-04-03 10:55:59 PST ---
(In reply to comment #12)
> (From update of attachment 135161 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135161&action=review
> 
> > Source/WebCore/editing/ReplaceSelectionCommand.cpp:1007
> > +    bool insertMailBlockquote = isMailBlockquote(refNode.get());
> 
> What if blockquote had a wrapping element (e.g. div)?
Good catch! Fix it and add a new test for it.
> 
> > Source/WebCore/editing/ReplaceSelectionCommand.cpp:1130
> > +                    insertParagraphSeparator(true, (!startIsInsideMailBlockquote && insertMailBlockquote));
> 
> The outer parenthesis is unnecessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.