[Webkit-unassigned] [Bug 84252] [Chromium] set layout fallback width width when FrameView is resized in AutoSizeMode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84252





--- Comment #10 from Fady Samuel <fsamuel at chromium.org>  2012-04-20 10:54:27 PST ---
(From update of attachment 137967)
View in context: https://bugs.webkit.org/attachment.cgi?id=137967&action=review

>> Source/WebCore/page/FrameView.cpp:2498
>> +#if ENABLE(VIEWPORT)
> 
> Why is this behind ENABLE(VIEWPORT)?

layoutFallbackWidth is logically associated with viewport computations and so it's behind ENABLE(VIEWPORT)

>> Source/WebCore/page/FrameView.cpp:2499
>> +        Page* page = frame()->page();
> 
> Why is this done inside of the loop instead of after the loop in this method?
> 
> I wonder why it is done here at all as opposed to some place closer to "page->chrome()->client()->layoutUpdated(frame());".

Good point. This doesn't need to be in WebCore at all I think. This can probably be moved to ChromeClientImpl.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.