[Webkit-unassigned] [Bug 84252] [Chromium] set layout fallback width width when FrameView is resized in AutoSizeMode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84252





--- Comment #9 from David Levin <levin at chromium.org>  2012-04-20 10:47:04 PST ---
(From update of attachment 137967)
View in context: https://bugs.webkit.org/attachment.cgi?id=137967&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=84252

What is this change fixing?

> Source/WebCore/ChangeLog:7
> +

Why is there no layout test? (Or any test at all?)

Is one possible? If not, why not?

> Source/WebCore/page/FrameView.cpp:2498
> +#if ENABLE(VIEWPORT)

Why is this behind ENABLE(VIEWPORT)?

> Source/WebCore/page/FrameView.cpp:2499
> +        Page* page = frame()->page();

Why is this done inside of the loop instead of after the loop in this method?

I wonder why it is done here at all as opposed to some place closer to "page->chrome()->client()->layoutUpdated(frame());".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.