[Webkit-unassigned] [Bug 84214] [BlackBerry] Loading media data with http authentication

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84214





--- Comment #3 from Jonathan Dong <jonathan.dong at torchmobile.com.cn>  2012-04-19 22:38:56 PST ---
(From update of attachment 137820)
View in context: https://bugs.webkit.org/attachment.cgi?id=137820&action=review

>> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:685
>> +            isConfirmed = frameView()->hostWindow()->platformPageClient()->authenticationChallenge(url, protectionSpace, credential);
> 
> that is a layering violation: webcore/platform code should not know about anything outside webcore/platform

Thanks Antonio, yes here's a layer violation, and Max has filed a bug https://bugs.webkit.org/show_bug.cgi?id=84291 which intends to solve the very issue. I guess we can let this patch in and fix this violation together with PR 84291, is that acceptable?

>> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:687
>> +            authChallenge.setCredential(string(credential.user().utf8().data()), string(credential.password().utf8().data()), static_cast<MMRAuthChallenge::CredentialPersistence>(credential.persistence()));
> 
> do we need string() here? does not it happen implicitly?

Yeah you are right, will remove this in the next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.