[Webkit-unassigned] [Bug 84214] [BlackBerry] Loading media data with http authentication

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84214





--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2012-04-19 21:48:16 PST ---
(From update of attachment 137820)
View in context: https://bugs.webkit.org/attachment.cgi?id=137820&action=review

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:685
> +        if (frameView() && frameView()->hostWindow())
> +            isConfirmed = frameView()->hostWindow()->platformPageClient()->authenticationChallenge(url, protectionSpace, credential);

that is a layering violation: webcore/platform code should not know about anything outside webcore/platform

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:687
> +            authChallenge.setCredential(string(credential.user().utf8().data()), string(credential.password().utf8().data()), static_cast<MMRAuthChallenge::CredentialPersistence>(credential.persistence()));

do we need string() here? does not it happen implicitly?

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:690
> +        authChallenge.setCredential(string(credential.user().utf8().data()), string(credential.password().utf8().data()), static_cast<MMRAuthChallenge::CredentialPersistence>(credential.persistence()));

ditto?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.