[Webkit-unassigned] [Bug 73300] ExecutableAllocator::cacheFlush() should flush valgrind's caches

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 15:49:32 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=73300





--- Comment #8 from Filip Pizlo <fpizlo at apple.com>  2012-04-19 15:49:32 PST ---
(In reply to comment #6)
> (From update of attachment 116934 [details])
> I'm not convinced this is a good patch.  Why don't we implement our own macros which optionally compile to Valgrind macros when valgrind is installed/enabled.

See Andy's response.

I think that (1) valgrind is a great tool for those using JSC on Linux and (2) this patch isn't going to get in anyone's way.

The only issue is to make sure that the license is appropriately compatible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list