[Webkit-unassigned] [Bug 73300] ExecutableAllocator::cacheFlush() should flush valgrind's caches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73300





--- Comment #7 from Andy Wingo <wingo at igalia.com>  2012-04-19 15:38:07 PST ---
(In reply to comment #6)
> (From update of attachment 116934 [details])
> I'm not convinced this is a good patch.  Why don't we implement our own macros which optionally compile to Valgrind macros when valgrind is installed/enabled.

The reason is that Valgrind headers are not normally installed; they are designed to be copied into your source tree.  The binary ABI is stable, but the source API is not (AFAIK).

Copying this single header into WTF is the right thing IMHO.  We already have our own abstractions to flush the icaches, and adding a new one will not help anything.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.