[Webkit-unassigned] [Bug 84246] [Qt] add LayoutTestController::setPrinting support to Qt unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 07:55:14 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84246


Milian Wolff <milian.wolff at kdab.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137894|0                           |1
        is obsolete|                            |
 Attachment #137902|                            |review?, commit-queue?
               Flag|                            |




--- Comment #11 from Milian Wolff <milian.wolff at kdab.com>  2012-04-19 07:55:14 PST ---
Created an attachment (id=137902)
 --> (https://bugs.webkit.org/attachment.cgi?id=137902&action=review)
patch that makes the Qt port properly handle setPrinting when creating pixel tests

- get rid of QWebFrame::paintPagesWithBoundaries, push implementation to DRTSupportQt
- return QImage instead of taking QImage& as argument in DRTSupportQt::paintPagesWithBoundaries

Thanks Simon, that really was badly done before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list