[Webkit-unassigned] [Bug 84246] [Qt] add LayoutTestController::setPrinting support to Qt unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84246


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137894|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #10 from Simon Hausmann <hausmann at webkit.org>  2012-04-19 06:57:25 PST ---
(From update of attachment 137894)
View in context: https://bugs.webkit.org/attachment.cgi?id=137894&action=review

Looks good in general, but I think the function should be moved. More detailed comment below.

> Source/WebKit/qt/Api/qwebframe.h:229
> +    void paintPagesWithBoundaries(QImage &);

This function is only relevant for DRT, so I think it should be moved to DumpRenderTreeSupport (I'm sure we can get the WebCore::Frame pointer there, too :). Also I think it should return a QImage instead of taking a reference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.