[Webkit-unassigned] [Bug 81332] Cache support for OpenTypeVerticalData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 19:48:58 PDT 2012


--- Comment #8 from Kenichi Ishibashi <bashi at chromium.org>  2012-04-17 19:48:58 PST ---
(From update of attachment 135005)
View in context: https://bugs.webkit.org/attachment.cgi?id=135005&action=review

>>> Source/WebCore/platform/graphics/FontCache.cpp:195
>>> +        return getCachedFontPlatformData(fontDescription, AtomicString(familyName.impl()->substring(1)), checkingAlternateName);
>> I recommend removing all "@"s in the front name before to avoid unnecessary recursion.
> While I agree with you as a general comment, in this specific case, family name having two or more leading '@' is very unlikely. If that assumption stands, I suppose this code runs more efficient than removing all leading '@' before the call. I can't do it without adding cycles on single case, can I, or do you think I'm assuming too much?

I concerned malicious inputs like "@@@.......". If my understanding is correct, familyName comes from user input. Does the spec (or implementation) limit the length of font name?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list