[Webkit-unassigned] [Bug 81332] Cache support for OpenTypeVerticalData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81332





--- Comment #7 from Koji Ishii <kojiishi at gmail.com>  2012-04-17 18:52:08 PST ---
(From update of attachment 135005)
View in context: https://bugs.webkit.org/attachment.cgi?id=135005&action=review

>> Source/WebCore/platform/graphics/FontCache.cpp:195
>> +        return getCachedFontPlatformData(fontDescription, AtomicString(familyName.impl()->substring(1)), checkingAlternateName);
> 
> I recommend removing all "@"s in the front name before to avoid unnecessary recursion.

While I agree with you as a general comment, in this specific case, family name having two or more leading '@' is very unlikely. If that assumption stands, I suppose this code runs more efficient than removing all leading '@' before the call. I can't do it without adding cycles on single case, can I, or do you think I'm assuming too much?

>> Source/WebCore/platform/graphics/opentype/OpenTypeVerticalData.h:61
>> +    bool m_inFontCache : 1;
> 
> Why this filed is a bit-field?

Ah, right, it doesn't save any for now. I'll remove it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.