[Webkit-unassigned] [Bug 82566] RenderTextControlSingleLine::scrollWidth/H/L/T should not call back to DOM tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82566


Tien-Ren Chen <trchen at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|RenderTextControlSingleLine |RenderTextControlSingleLine
                   |::scrollWidth/scrolHeight/s |::scrollWidth/H/L/T should
                   |crollLeft/scrollTop should  |not call back to DOM tree
                   |not call back to DOM tree   |




--- Comment #8 from Tien-Ren Chen <trchen at chromium.org>  2012-04-16 16:54:31 PST ---
(In reply to comment #7)
> (From update of attachment 136327 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136327&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        No new tests. No change in behavior.
> 
> As asked once but I did not get any answer: do you have a test case for that change?
> I don't fear the change in behavior (very unlikely), more the badness of having layout called recursively.

No, I mean the opposite. There should be no visible difference in layout behavior, and that is what we want. I can't observe anything weird at this time.

> > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:695
> > +        RenderBox* rend = innerTextElement()->renderBox();
> 
> Again, don't abbreviate.

Ugh that's the same copy & paste from Element. Anyway I'll change it to "box", sounds better than "rend".

> > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:714
> > +        return adjustForAbsoluteZoom(rend->scrollLeft(), rend);
> 
> If you are going to update the getters, I would like the setters to be updated in the same way.

Alright. Seems like the setter on Element just calls the setter on the RenderBox anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.