[Webkit-unassigned] [Bug 82566] RenderTextControlSingleLine::scrollWidth/H/L/T should not call back to DOM tree

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 16 16:32:45 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82566





--- Comment #7 from Julien Chaffraix <jchaffraix at webkit.org>  2012-04-16 16:32:45 PST ---
(From update of attachment 136327)
View in context: https://bugs.webkit.org/attachment.cgi?id=136327&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests. No change in behavior.

As asked once but I did not get any answer: do you have a test case for that change?

I don't fear the change in behavior (very unlikely), more the badness of having layout called recursively.

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:695
> +        RenderBox* rend = innerTextElement()->renderBox();

Again, don't abbreviate.

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:714
> +        return adjustForAbsoluteZoom(rend->scrollLeft(), rend);

If you are going to update the getters, I would like the setters to be updated in the same way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list