[Webkit-unassigned] [Bug 78095] [GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78095


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136460|review?                     |review+
               Flag|                            |




--- Comment #26 from Martin Robinson <mrobinson at webkit.org>  2012-04-16 08:53:23 PST ---
(From update of attachment 136460)
View in context: https://bugs.webkit.org/attachment.cgi?id=136460&action=review

Looks good, but take a look at my comment below before landing.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:179
> +bool doGstInit()

Is this used outside the file now? It's no longer static. Now that you have initializeGStreamer, perhaps it makese sense to rename this method to differeniate it from initializeGStreamer. How about initializeGStreamerAndRegisterWebKitWebSrc?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.