[Webkit-unassigned] [Bug 78095] [GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78095





--- Comment #27 from Philippe Normand <pnormand at igalia.com>  2012-04-16 09:05:48 PST ---
(From update of attachment 136460)
View in context: https://bugs.webkit.org/attachment.cgi?id=136460&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:179
>> +bool doGstInit()
> 
> Is this used outside the file now? It's no longer static. Now that you have initializeGStreamer, perhaps it makese sense to rename this method to differeniate it from initializeGStreamer. How about initializeGStreamerAndRegisterWebKitWebSrc?

I agree about renaming but I saw some branches of this code doing additional elements registration. So maybe we should have a less specific name, like initializeGStreamerAndAndRegisterWebKitElements ? long names ftw :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.