[Webkit-unassigned] [Bug 77520] [WK2] Modify parameters of willSubmitForm callback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77520





--- Comment #15 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2012-04-16 06:11:39 PST ---
(In reply to comment #14)
> (From update of attachment 137062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137062&action=review
> 
> This seems like a bad idea, and too expensive for the general case.  The bundle can be used to annotate the callback with this data if it necessary.

First of all thanks for your review.
Do you mean that expanded version of willSubmitForm callback should be moved to WKBundlePage.h and current API of WKPage.h shouldn't be changed?

Isn't it a misunderstanding to keep in the fact two different callbacks?
I agree that this callback doesn't require any sync between UIProcess and WebProcess. Is it the main reason of moving it to WKBundlePage.h ?

> 
> > Source/WebKit2/UIProcess/API/C/WKPage.h:140
> > +typedef void (*WKPageWillSubmitFormCallback)(WKPageRef page, WKFrameRef frame, WKFrameRef sourceFrame, WKArrayRef textFieldsProperties, WKDictionaryRef formAttributes, WKTypeRef userData, WKFormSubmissionListenerRef listener, const void* clientInfo);
> 
> This will break existing clients.  You can;t just change delegates like this, you need to version it.

Make sense, thanks. It will probably fix build break on mac port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.