[Webkit-unassigned] [Bug 77520] [WK2] Modify parameters of willSubmitForm callback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77520


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137062|review?                     |review-
               Flag|                            |




--- Comment #14 from Sam Weinig <sam at webkit.org>  2012-04-15 16:19:11 PST ---
(From update of attachment 137062)
View in context: https://bugs.webkit.org/attachment.cgi?id=137062&action=review

This seems like a bad idea, and too expensive for the general case.  The bundle can be used to annotate the callback with this data if it necessary.

> Source/WebKit2/UIProcess/API/C/WKPage.h:140
> +typedef void (*WKPageWillSubmitFormCallback)(WKPageRef page, WKFrameRef frame, WKFrameRef sourceFrame, WKArrayRef textFieldsProperties, WKDictionaryRef formAttributes, WKTypeRef userData, WKFormSubmissionListenerRef listener, const void* clientInfo);

This will break existing clients.  You can;t just change delegates like this, you need to version it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.