[Webkit-unassigned] [Bug 83879] [GTK][WK2] Implement API for Geolocation permission requests in the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83879





--- Comment #13 from Mario Sanchez Prada <msanchez at igalia.com>  2012-04-16 03:22:16 PST ---
(From update of attachment 137082)
View in context: https://bugs.webkit.org/attachment.cgi?id=137082&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:78
>> +    G_OBJECT_CLASS(webkit_geolocation_permission_request_parent_class)->finalize(object);
> 
> You should check here whether request has been made or not, and call deny if it wasn't made. That's what WebKitWebView::permission-request signal documentation says.

True.

>> Tools/ChangeLog:9
>> +        to allow users handle the Geolocation permission requests.
> 
> Please add unit tests, and maybe leave minibrowser impl for a following patch.

Will add later, of course. This is just a preliminar version of the patch.

>> Tools/MiniBrowser/gtk/BrowserWindow.c:293
>> +                                                    NULL);
> 
> What do you think about using GtkInfoBar instead of a popup dialog?

I think that for a test app like MiniBrowser a GtkDialog is more than enough, and simpler to implement.

If you strongly think we should use an info bar I will change it, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.