[Webkit-unassigned] [Bug 83879] [GTK][WK2] Implement API for Geolocation permission requests in the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83879





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-16 02:15:27 PST ---
(In reply to comment #11)
> (From update of attachment 137092 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137092&action=review
> 
> Thanks for the review. Will be addressing those issues in a follow-up patch
> 
> >> Source/WebKit2/UIProcess/API/gtk/WebKitPermissionRequest.cpp:62
> >> +        iface->allow(request);
> > 
> > I guess this should be a required method, so we should enforce to be implemented, no?
> 
> I just followed the pattern I could see in other places in WebCore:
>   - WebCore/bindings/gobject/WebKitDOMEventTarget.cpp 
>   - WebKit/gtk/webkit/webkitspellchecker.cpp 
> 
> After all, it's an interface, you will be either completely implementing it or not, but not doing things half-way :-)

Exactly, so it doesn't make sense to create a request object that doesn't provide implementation for allow and deny, no?

> >> Source/WebKit2/UIProcess/API/gtk/WebKitPermissionRequest.h:36
> >> +#define WEBKIT_PERMISSION_REQUEST_GET_IFACE(obj) (G_TYPE_INSTANCE_GET_INTERFACE((obj), WEBKIT_TYPE_PERMISSION_REQUEST, WebKitPermissionRequestIface))
> > 
> > Don't add CLASS macros for interfaces, just WEBKIT_TYPE_PERMISSION_REQUEST, WEBKIT_PERMISSION_REQUEST, WEBKIT_IS_PERMISSION_REQUEST and WEBKIT_PERMISSION_REQUEST_GET_IFACE
> 
> Ok (we should fix WebCore/bindings/gobject/WebKitDOMEventTarget.h too)

No, that's already public API, so it can be removed. It's harmless in any case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.