[Webkit-unassigned] [Bug 83748] [Chromium] Remove existing markers when updating markers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83748





--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2012-04-13 00:57:42 PST ---
(In reply to comment #11)
> Greetings Niwa-san,
> 
> Thanks for your comment. To move this code to didCheckSucceeded, we need to copy a sequence check 'if (m_processingRequest->sequence() != sequence)...' in SpellChecker::didCheck() to prevent removing existing markers by mistakes. Is it OK to copy it?

But there's also an assertion that ASSERT(m_processingRequest->sequence() == sequence); It's very odd that we assert and then bail out if that were not the case. Anyway, I don't think duplicating that code is that big of a deal. It's probably better than adding an anxious boolean flag.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.