[Webkit-unassigned] [Bug 83748] [Chromium] Remove existing markers when updating markers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83748





--- Comment #11 from Hironori Bono <hbono at chromium.org>  2012-04-13 00:49:51 PST ---
Greetings Niwa-san,

Thanks for your comment. To move this code to didCheckSucceeded, we need to copy a sequence check 'if (m_processingRequest->sequence() != sequence)...' in SpellChecker::didCheck() to prevent removing existing markers by mistakes. Is it OK to copy it?

Regards,

Hironori Bono

(In reply to comment #10)
> (From update of attachment 137041 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137041&action=review
> 
> > Source/WebCore/editing/SpellChecker.cpp:188
> > +    if (eraseMarkers) {
> > +        unsigned markers = 0;
> > +        if (m_processingRequest->mask() & TextCheckingTypeSpelling)
> > +            markers |= DocumentMarker::Spelling;
> > +        if (m_processingRequest->mask() & TextCheckingTypeGrammar)
> > +            markers |= DocumentMarker::Grammar;
> > +        if (markers)
> > +            m_frame->document()->markers()->removeMarkers(m_processingRequest->checkingRange().get(), markers);
> > +    }
> 
> Can't we add this code in didCheckSucceeded instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.