[Webkit-unassigned] [Bug 83777] Introduce MenuItemID to autofill popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83777





--- Comment #4 from Kent Tamura <tkent at chromium.org>  2012-04-12 19:31:09 PST ---
(From update of attachment 136895)
View in context: https://bugs.webkit.org/attachment.cgi?id=136895&action=review

>> Source/WebKit/chromium/public/WebAutofillClient.h:43
>> +    enum {
> 
> nit: we usually name enums, and then we use the enum name
> as the typename elsewhere.
> 
> shouldn't didAcceptAutofillSuggestion use a named enum type
> for the itemID parameter?
> 
> please also see:
> http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

In my understanding, we usually use positive numbers for the ID and these symbols are special values.  Maybe we shouldn't use the enum name as the type?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.