[Webkit-unassigned] [Bug 83777] Introduce MenuItemID to autofill popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83777


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136895|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-04-12 14:00:44 PST ---
(From update of attachment 136895)
View in context: https://bugs.webkit.org/attachment.cgi?id=136895&action=review

> Source/WebKit/chromium/public/WebAutofillClient.h:43
> +    enum {

nit: we usually name enums, and then we use the enum name
as the typename elsewhere.

shouldn't didAcceptAutofillSuggestion use a named enum type
for the itemID parameter?

please also see:
http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

> Source/WebKit/chromium/public/WebView.h:364
> +        const WebVector<int>& itemIDs) = 0;

Chrome doesn't yet call this function?  It is easy to land without breaking Chrome?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.