[Webkit-unassigned] [Bug 83007] [EFL] EFL's LayoutTestController overridePreference implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83007





--- Comment #7 from Rafael Antognolli <antognolli at profusion.mobi>  2012-04-11 07:48:28 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 136650 [details] [details])
> > The ewk_view_setting_{get,set}() stuff isn't very EFL-like, and is yet another place to maintain when adding/removing settings. I don't like this. 
> > 
> > One could easily write LayoutTestController::overridePreference() by calling directly the already existing ewk_view_setting family of functions, without sacrificing readability at the call site.
> > 
> > Informal r-.
> 
> Mikhail's approach has been up for discussion before this patch was submitted, pls compare: https://lists.webkit.org/pipermail/webkit-efl/2012-April/000158.html 
> Feedback there had been rather positive.

Ok, we can move the discussion back to the ML if necessary. I'm going to answer to that thread too.

Regards,
Rafael

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.