[Webkit-unassigned] [Bug 83330] Allow certain Char events in fullscreen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83330





--- Comment #5 from Cem Kocagil <cem.kocagil+webkit at gmail.com>  2012-04-06 13:25:18 PST ---
(In reply to comment #4)
> (From update of attachment 135938 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135938&action=review
> 
> It is expected behavior that keypress events (corresponding to Char) have a character code, but no virtual key code.

In that case, is PlatformKeyboardEvent.h inaccurate? Or by "no virtual key code" do you mean a windowsVirtualKeyCode value of zero?

> It's quite unfortunate that information about key bindings is hardcoded here. In fact, existing code below makes me quite suspicious (why VK_BACK? why VK_OEM_1?)

Without VK_BACK, backspace on textboxes do not work and takes us back to the previous page. Without VK_OEM_1, I think the semicolon key wouldn't work.

> > Source/WebCore/page/EventHandler.cpp:2728
> > +        char character = keyEvent.text()[0];
> 
> This character is Unicode, so converting to char loses high bits. Also, this should check that length of text is 1.

Can we not assume that the string always has a null character?
If windowsVirtualKeyCode is supposed to give us the char code, should we use it instead of ".text()[0]"?

I'll fix these and character type and resubmit a new patch, if these are the reasons for the r-. Please let me know if there's any particular refactoring that you think should be done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.