[Webkit-unassigned] [Bug 83330] Allow certain Char events in fullscreen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83330


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135938|review?                     |review-
               Flag|                            |




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2012-04-06 11:16:49 PST ---
(From update of attachment 135938)
View in context: https://bugs.webkit.org/attachment.cgi?id=135938&action=review

It is expected behavior that keypress events (corresponding to Char) have a character code, but no virtual key code.

It's quite unfortunate that information about key bindings is hardcoded here. In fact, existing code below makes me quite suspicious (why VK_BACK? why VK_OEM_1?)

> Source/WebCore/page/EventHandler.cpp:2728
> +        char character = keyEvent.text()[0];

This character is Unicode, so converting to char loses high bits. Also, this should check that length of text is 1.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.