[Webkit-unassigned] [Bug 83030] [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 00:00:36 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83030





--- Comment #5 from Christophe Dumez <christophe.dumez at intel.com>  2012-04-06 00:00:36 PST ---
(In reply to comment #4)
> > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:769
> >      if (!shouldFallBack(err))
> >          return;
> 
> This check has no effect now; shouldn't you call ewk_frame_load_error after this check?

Some tests did not pass due to missing load errors, so I had to move the error signaling before the shouldFallBack() check. Note that the GTK port is doing the same. However, they have code after the shouldFallback() check. Maybe I should add a notImplemented() after the check for clarity?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list