[Webkit-unassigned] [Bug 83030] [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83030





--- Comment #4 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-05 18:58:45 PST ---
(From update of attachment 135814)
View in context: https://bugs.webkit.org/attachment.cgi?id=135814&action=review

Looks almost good; please also explain in the ChangeLog the reason for moving the ewk_frame_load_{finished,error} signals.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:-244
> -    if (m_loadError.isNull())
> -        ewk_frame_load_finished(m_frame, 0, 0, 0, 0, 0);
> -    else {
> -        ewk_frame_load_finished(m_frame,
> -                                m_loadError.domain().utf8().data(),
> -                                m_loadError.errorCode(),
> -                                m_loadError.isCancellation(),
> -                                m_loadError.localizedDescription().utf8().data(),
> -                                m_loadError.failingURL().utf8().data());
> -    }

Please add a notImplemented() call here.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:769
>      if (!shouldFallBack(err))
>          return;

This check has no effect now; shouldn't you call ewk_frame_load_error after this check?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.